Phase 1 Code Review Feedback

    $SRC/cmd/nwam/netcfgd
    $SRC/cmd/nwam/nwamd
    $SRC/cmd/nwam/common /* for common themes like daemonize() */

   for (i = 0; i < lwp->lw_num; i++) {
                free(..);
   }

    icfg_open()
    plumb interface
    add addresses
    ... other stuff with the interface..

  2570                          } else {
  2571                                  ret = ICFG_NO_UNPLUMB_ARP;
  2572                                  goto done;
  2573                          }

           static void *
           nwamd_dlpi_thread(void *arg)
           {
                int rc;
                dlpi_handle_t *dh = arg;

                for (;;) {
                        rc = dlpi_recv(*dh, NULL, NULL, NULL, NULL, -1, NULL);
                        if (rc != DLPI_SUCCESS) {
                                nlog(LOG_ERR, "nwam_dlpi_thread: dlpi_recv "
                                    "failed: %s", dlpi_strerror(rc));
                                break;
                        }
                }
                return (NULL);
           }

  err = nwam_value_get_uint64(activationval, &activation);
  nwam_value_free(activationval);
  if (err != NWAM_SUCCESS) {
        nlog(...);
        return (0);
  }

  case NWAM_STATE_OFFLINE_TO_ONLINE:
  case NWAM_STATE_ONLINE_TO_OFFLINE:
  case NWAM_STATE_ONLINE:
        nwamd_ncu_state_machine(event->event_object);
        break;

          #define dprintf(...)     nlog(LOG_DEBUG, __VA_ARGS__)

    358             (chmod(NWAM_DOOR_DIR, 07555) < 0 ||

    56  struct nwam_value
    57  {
  should be collapsed to one line:
    56  struct nwam_value {

  nwam_aux_state_t, NWAM_AUX_STATE*STRING,
  nwam_activation_mode_t, NWAM_ACTIVATION_MODE_*STRING,
  nwam_condition_t, NWAM_CONDITION*STRING,
  nwam_condition_object_type_t,  NWAM_CONDITION_OBJECT_TYPE*STRING
  nwam_configsrc_t, NWAM_CONFIGSRC_*STRING
  nwam_nameservices_t, NWAM_LOC_PROP*
  nwam_ncu_type_t, NWAM_NCU_TYPE*STRING
  nwam_ncu_class_t, NWAM_NCU_CLASS_*STRING
  nwam_iptun_type_t, NWAM_IPTUN_TYPE*STRING
  nwam_addrsrc_t, NWAM_ADDRSRC*STRING,
  nwam_priority_mode_t, NWAM_PRIORITY_MODE*STRING

                typedef int (cmd_handle_func_t)(int, char **);

          if (cmd_num != CMD_LIST && type == NWAM_OBJECT_TYPE_NONE)

          if ((execname = strrchr(argv[0], '/')) == NULL)
                execname = argv[0];
          else
                execname++;

          if (got_enm_handle) {
              prop_type = pt_to_prop_type(pt_type, NWAM_OBJECT_TYPE_ENM);
              if (prop_type == NULL)
                      goto prop_error;

              /* check if property can be set */
              if (is_prop_read_only(prop_type, NWAM_OBJECT_TYPE_ENM))
                      goto read_only;
              if (!show_prop_test(prop_type, enm_prop_display_entry_table,
                  NWAM_OBJECT_TYPE_ENM))
                       goto skip_prop;
              /* ... */
          } else if (got_wlan_handle) {
              prop_type = pt_to_prop_type(pt_type,
                  NWAM_OBJECT_TYPE_KNOWN_WLAN);
              if (prop_type == NULL)
                      goto prop_error;

              /* check if property can be set */
              if (is_prop_read_only(prop_type, NWAM_OBJECT_TYPE_KNOWN_WLAN))
                      goto read_only;
              if (!show_prop_test(prop_type, wlan_prop_display_entry_table,
                  NWAM_OBJECT_TYPE_KNOWN_WLAN))
                      goto skip_prop;
              /* ... */
          } else if (got_ncu_handle) {
              /* ... */

          handle_type = get_handle_type();
          if ((prop_type = pt_to_prop_type(pt_type, handle_type)) == NULL)
                goto prop_error;
          if (is_prop_read_only(prop_type, handle_type))
                goto read_only;
          if (!show_prop(prop_type, prop_table[handle_type], handle_type))
                goto skip_prop;

          int
          destroy_ncp_callback(nwam_ncp_handle_t ncp, void *arg)
          {
                return (destroy_ret(nwam_ncp_destroy(ncp,
                   NWAM_FLAG_DO_NOT_FREE));
          }

          int
          prop_to_pt(const char *nwam_prop, nwam_object_type_t type)
          {
                nwam_prop_table_t *table;

                assert(type >= 0 && type < NWAM_OBJECT_TYPE_KNOWN_WLAN);
                table = prop_tables[type];

                for (i = 0; table.prop_type != NULL; i++) {
                        if (strcmp(nwam_prop, prop_table[i].prop_type) == 0)
                                return (prop_table[i].type);
                }
                return (-1);
          }

          int
          list_obj_callback(nwam_obj_t *obj, void *arg,
              const char *objname, const char *objplural)
          {
                 char           *name;
                 nwam_error_t   ret;
                 boolean_t      *list_msgp = arg;

                 if (*list_msgp) {
                         (void) printf("%s:\n", objplural);
                        *list_msgp = B_FALSE;
                 }

                 ret = (*obj->namefunc)(obj, &name);
                 if (ret != NWAM_SUCCESS) {
                        warn_nwerr("List error: cannot get %s", objname);
                        return (1);
                 }

                 (void) printf("\t%s\n", name);
                 free(name);
                 return (0);
          }

          ... then e.g.:

          int
          list_enm_callback(nwam_enm_handle_t enm, void *arg)
          {
                return (list_obj_callback(enm, arg, "ENM", "ENMs"));
          }

                if (cmd->cmd_res1_type == RT1_UNKNOWN) {
                        for (i = RT1_MIN; i < RT1_MAX; i++)
                                export_l1[i] = B_TRUE;
                } else {
                        export_l1[cmd->cmd_res1_type] = B_TRUE;
                }